Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] map_values(@base64d) results in undefined filter #192

Closed
lukehsiao opened this issue Jul 2, 2024 · 3 comments
Closed

[bug] map_values(@base64d) results in undefined filter #192

lukehsiao opened this issue Jul 2, 2024 · 3 comments

Comments

@lukehsiao
Copy link

lukehsiao commented Jul 2, 2024

This command used to work for us in v1.4.0

❯ echo '{"a": "aGVsbG8=", "b": "d29ybGQ="}' | jaq "map_values(@base64d)"
Error: undefined filter
  ╭─
  │
1 │ map_values(@base64d)
  ┆            ────┬───
  ┆                │
  ┆                ╰───── undefined filter
──╯
❯ jaq --version
jaq 1.5.0

But doesn't anymore in v1.5.0. The same command does still work with jq.

❯ echo '{"a": "aGVsbG8=", "b": "d29ybGQ="}' | jq "map_values(@base64d)"
{
  "a": "hello",
  "b": "world"
}

Per the readme, base64d does still seem to be a valid filter.

With jaq 1.4.0:

❯ cargo install --locked jaq@1.4.0
❯ jaq --version
jaq 1.4.0
❯ echo '{"a": "aGVsbG8=", "b": "d29ybGQ="}' | jaq "map_values(@base64d)"
{
  "a": "hello",
  "b": "world"
}
@lukehsiao lukehsiao changed the title map_values(@base64d) results in undefined filter [bug] map_values(@base64d) results in undefined filter Jul 2, 2024
@01mf02
Copy link
Owner

01mf02 commented Jul 3, 2024

Hi @lukehsiao, thanks for spotting this. I forgot to reimplement @base64d in my last refactoring. It should work as of commit 3b89a88.

@lukehsiao
Copy link
Author

It would be great to get a patch release (e.g., 1.5.1) with the fix if you have the time :). In the meantime I'll move back to 1.4.0.

@01mf02
Copy link
Owner

01mf02 commented Jul 7, 2024

@lukehsiao, 1.5.1 is out now. :) Have fun with it, and thanks again for spotting this issue!

@01mf02 01mf02 closed this as completed Jul 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants