Skip to content
This repository has been archived by the owner on Mar 28, 2018. It is now read-only.

Networking: Support Dynamic Network Connect/Disconnect #388

Closed
mcastelino opened this issue Nov 10, 2016 · 5 comments
Closed

Networking: Support Dynamic Network Connect/Disconnect #388

mcastelino opened this issue Nov 10, 2016 · 5 comments

Comments

@mcastelino
Copy link
Contributor

docker network connect
docker network disconnect

Allows you to connect a network to an running container.
cc-oci-runtime does not support this capability today.

@grahamwhaley
Copy link

@mcastelino before somebody goes digging, do you have ideas why cc-oci-runtime does not currently support it? Any idea what is missing/wrong?

@mcastelino
Copy link
Contributor Author

@grahamwhaley there is nothing wrong in clear containers. Container networking assumes transparent use of namespaces and the ability for a container to see anything that is inserted into the namespace automatically. As clear containers have an additional level of separation (VT-x) in addition to being namespaced, the clear container code base has to be enhanced to detect any additional devices that show up in the name space and plug them into the VT-x based runtime.

@louisekrug
Copy link

here in BT we have a number of potential use cases that all rely on multiple network interfaces, so i'd be interested in any solution to this

@mcastelino
Copy link
Contributor Author

mcastelino commented Nov 18, 2016

@louisekrug we will support multi network interfaces. Use cases such as docker swarm require this functionality. This feature will be added shortly. PR #399

The gap currently is the dynamic connection of a network to an already running container using network connect. Do you use the dynamic network connect capability?

This is due to the nature of the OCI spec which currently does not provide a notification of this network connect. It would be of interest to us, if there is need for this for your deployment, which would mean we will need to monitor the container namespace at runtime for additional interfaces and hot plug them into the Clear Container VM.

@amshinde amshinde self-assigned this Jan 27, 2017
@jcvenegas jcvenegas added this to enhancements in 2.1.x Stable May 3, 2017
@jcvenegas jcvenegas moved this from enhancements to 3.0 in 2.1.x Stable May 5, 2017
@sameo
Copy link

sameo commented May 11, 2017

Now tracked as part of the virtcontainers project:
containers/virtcontainers#241

@sameo sameo closed this as completed May 11, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Development

No branches or pull requests

6 participants