install .dll to bin/, not to lib/ #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me - in fact I thought I'd already made that change, but apparently not. We are working on a few more changes for Windows builds at the moment. I saw the patch that you've created to make Windows builds work for your product and we should be able to reduce that a bit. We used to do cross-compile with Mingw, but haven't since switching to CMake, but that should be easy enough to improve. |
starius
added a commit
to LuaAndC/mxe
that referenced
this pull request
Jun 5, 2016
Some patches are not needed anymore: * "add Libs.private to fix linking errors" was fixed in intel/hyperscan#18 * "fix linking against gtest in shared mode" and "fix linking errors in shared mode" were fixed in intel/hyperscan#19 * "install .dll to bin/, not to lib/" intel/hyperscan#21
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.