Skip to content
This repository has been archived by the owner on Aug 20, 2020. It is now read-only.

enable xdg for next crosswalk rebase #272

Closed
wants to merge 3 commits into from
Closed

enable xdg for next crosswalk rebase #272

wants to merge 3 commits into from

Conversation

rzr
Copy link

@rzr rzr commented Aug 20, 2014

No description provided.

Signed-off-by: Philippe Coval <philippe.coval@open.eurogiciel.org>
Signed-off-by: Philippe Coval <philippe.coval@open.eurogiciel.org>
Since xdg-shell is not a stable feature
it should be enabled at runtime using env variable.

See 6d12d98 which introduces OZONE_WAYLAND_USE_XDG_SHELL

Signed-off-by: Philippe Coval <philippe.coval@open.eurogiciel.org>
@kalyankondapally
Copy link
Contributor

@rzr The only problem I see here is with the version of xdg_shell. The minimum wayland version we support is 1.4, but xdg_shell protocol I believe is close to the one from 1.5 version. Now, anybody compiling against 1.4 will have problems ?

@rzr
Copy link
Author

rzr commented Aug 20, 2014

True supporting multiple xdg version could be hard to maintain , but since it's supposed to be stable and part of wayland next version (/me join his hands) let's focus on the latest version... and disable it by default unless user dare to enable it using env variable from my previous commit ...

I would add this in the release note as known limitation for wayland-1.4 users , just curious are there any distro that integrate it using 1.4 . so far tizen switched to 1.5 AFAIK.

But to answer your question, if version are mismatching AND the feature enabled with env var, then expect some warning logs in the console, no more arm than I know ... maybe it will stress wayland a bit since log of lines will be printed in loop ...

@Tarnyko
Copy link

Tarnyko commented Aug 20, 2014

For the record, upstream Weston (not Tizen's one) did not have xdg-shell at all.
So, this is very unlikely to cause problems unless the user uses a development version of Weston between 1.4 and 1.5, which I believe is an unsupported scenario.
If this is the regular Weston 1.4 release, Ozone will just fall back to wl_shell.

@kalyankondapally
Copy link
Contributor

Merged

@kalyankondapally kalyankondapally added this to the Harvest milestone Aug 21, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants