Give a name to unnamed union in CborEncoder #35
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbor.h contains an unnamed union in CborEncoder structure, this functionality is not always supported by all compilers, especially it seems that the Blackfin build on buildroot fails (with gcc 4.3). This patch names this union "data". Signed-off-by: Fabrice Fontaine <fabrice.fontaine@orange.com>
|
Interesting, I thought anonymous unions were a C99 feature, but they're actually C11. |
|
Merged as 0e1440a |
|
Reverting this in the master branch. I'm re-applying to the dev branch. |
|
Re-applied with fixes to dev branch, as ede7f14. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cbor.h contains an unnamed union in CborEncoder structure, this functionality is
not always supported by all compilers, especially it seems that the Blackfin
build on buildroot fails (with gcc 4.3). This patch names this union "data".
Signed-off-by: Fabrice Fontaine fabrice.fontaine@orange.com