Change EncoderDecoder.Feed.config visibility from private to public
#70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
05nelsonm
commented
Jan 23, 2023
There was a problem hiding this comment.
Definitely need to make extension functions for Feed, especially with consuming more things than just a Byte, but Iterables and even the ability to have a transformation lambda there.
File("/tmp/asldkjfasldf").outputStream().use { oStream ->
val feed = myEncoder.newEncoderFeed { encodedByte ->
oStream.write(encodedByte.toInt())
}
feed.consumeAll("Hello World!")
}Actually... is consume a better name than update? Feeding, consuming, "Byte" 🤣 ?
Comment on lines
+128
to
+134
| val size: Int = feed.config.decodeOutMaxSize(file.length()).let { size -> | ||
| if (size > 4096L) { | ||
| 4096 | ||
| } else { | ||
| size.toInt() | ||
| } | ||
| } |
There was a problem hiding this comment.
Would make for a fantastic extension function for EncoderDecoder.Config
This was referenced Jan 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #69
Also adds an example of streaming encoded data to, and decoded data from a
Filein the sample:app