Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fallback to BCryptGenRandom for Mingw targets #8

Open
05nelsonm opened this issue Jan 12, 2023 · 0 comments
Open

Add fallback to BCryptGenRandom for Mingw targets #8

05nelsonm opened this issue Jan 12, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@05nelsonm
Copy link
Owner

05nelsonm commented Jan 12, 2023 •
edited
Loading

The Mingw implementation needs to be expanded such that it checks what version it is on and to use the appropriate cryptographic method. The current implementation, which uses BCryptGenRandom, is limited to Windows Vista SP2 or above.

See https://learn.microsoft.com/en-us/windows/win32/api/bcrypt/nf-bcrypt-bcryptgenrandom
@05nelsonm 05nelsonm added the enhancement New feature or request label Jan 12, 2023
@05nelsonm 05nelsonm mentioned this issue Jan 12, 2023
Merged
@05nelsonm 05nelsonm changed the title Add platform checks to Mingw implementation Add version checks and fallbacks to Mingw implementation Jan 13, 2023
@05nelsonm 05nelsonm changed the title Add version checks and fallbacks to Mingw implementation Add fallback to BCryptGenRandom for Mingw targets Jan 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@05nelsonm