-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
是否可以把icon包裹组件功能合并到svg组件里面 #191
Comments
包裹的话实际上就和具体的组件库,这咋说呢...应该是不会放在这个库里的,毕竟是组件库无关 |
从维护角度讲生成那么多图标 again 其实也是个问题,现在发一次要二十多分钟😂 |
我构建一下,macbook Pro风扇都要炸了 |
其实我就是想做具体的组件库,我需要合并这些功能,你的考虑确实不错,还有就是不是很重要的图标,希望阿里fonticon的symbol注入比较合适 |
至于打包的问题我觉得吧,如果你想基于这个库封装,在自己的库里写一个生成脚本是最划算的 我之前没套任何东西就是知道每个库有自己的想法,如果我这边做了那外部就没有定制性了 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
每个svg组件外面必须包裹一个icon组件吗?觉得很繁琐,能不能icon组件的功能合并到svg组件里面去
单独使用svg组件好像也是可以的,可能没有全局的样式
The text was updated successfully, but these errors were encountered: