Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fonts #12

Closed
enumag opened this issue Nov 18, 2017 · 11 comments
Closed

Fonts #12

enumag opened this issue Nov 18, 2017 · 11 comments

Comments

@enumag
Copy link
Member

enumag commented Nov 18, 2017

@P-Chang Would it be possible to hack the DLL to use some different fonts? Firstly it could fix the red X issue in japanese and secondly the current font is awful when turned to italics - so bad that we hardly ever use them.

@P-Chang
Copy link
Contributor

P-Chang commented Nov 18, 2017

http://www.mediafire.com/file/4u3f8q8y3wk5kqq/fonts.rar

This is font texture that is stored in UnityAssetBundle. And it is controlled by TextMeshPro.
And These image can't be showed correctly without graphic editor that have alpha map support.

If I make my own game in Unity with TextMeshPro, I might find the way to replace font.
But there are really few possibility.

@enumag
Copy link
Member Author

enumag commented Nov 18, 2017

Oh my. is this for real? I mean that's really not something we want to edit. At best someone might be able to add some chars to fix the red X issue but I consider even that unlikely.

However I don't see any italic characters there so I think italics are handled by the DLL just by skewing the characters when rendering them. Which means it might be possible to make it skew it a bit less than it does now. What do you think?

@P-Chang
Copy link
Contributor

P-Chang commented Nov 18, 2017

I didn't read console arcs yet. Could you show me specific part of using italic character?

@enumag
Copy link
Member Author

enumag commented Nov 18, 2017

I didn't read it yet either. And in those instances where it was used we removed it later because it looked just awful.

Anyway you can try italics by yourself. If I remember correctly you just need to add <i>...</i> around the text that you want italic..

@P-Chang
Copy link
Contributor

P-Chang commented Nov 18, 2017

[Thanks, I probably found italic control. but my Math score were always bad, I can delete it, but I have no idea for less it. if you want to less it, please change numbers and write in comment.] edited

I re-read this thread 07th-mod/higurashi-console-arcs#5

@DoctorDiablo use italic because he use italic as Japanese 『』
If you thought it was awful because character over-wrap "-", is it enough that change "Saeki-san" to "Saeki - san" ?

and I found TextMeshPro Tag list.
h ttp://digitalnativestudios.com/textmeshpro/docs/rich-text/

We can use <u>...</u>

20171119042312_1

Isn't it good enough ?

@P-Chang
Copy link
Contributor

P-Chang commented Nov 18, 2017

20171119050845_1
20171119042400_1

It was easy that I thought.

But italic that was less doesn't looks like specific dialog for me. I prefer <u>...</u> or other tags

@enumag
Copy link
Member Author

enumag commented Nov 18, 2017

The second screenshot is the original and the first is after your modification, right? Great job!

Italic is not supposed to be as distinctive as underline or bold so it's absolutely fine as it is in your first screenshot. I don't think underscore should be used in VN though.

You don't need to create new DLLs for all chapters because of this - it's minor and we will not need it immediately. Just add it whenever you will compile them. Thank you!


@DoctorDiablo TL;DR for you: You can use italic in console arcs now when appropriate. @P-Chang managed to fix it so it won't look so awful in the next release.

@P-Chang
Copy link
Contributor

P-Chang commented Nov 19, 2017

It is right. first one is modded font.
This method have too many code, so if it could be replace to another tag, I prefer replace.

But if there are no good replacement until next update, I'll include it.

@enumag
Copy link
Member Author

enumag commented Nov 19, 2017

You mean you want to change for example <u>...</u> to be the new italic instead of it's original meaning?

@P-Chang
Copy link
Contributor

P-Chang commented Nov 19, 2017

If there are another good tag, yes.
I just scare this most long code.

But my English knowledge is cheap. so, I also prefer original meaning and I'll leave it you and @DoctorDiablo .

However I can't understand translation rule of 『』 and italic.
I think 「」 and 『』 don't have big differences.

There are many tags, so I think there are way with leaving this code.
But if you want to use new italic font, I'll apply it in next update.

@enumag
Copy link
Member Author

enumag commented Nov 19, 2017

In my opinion just changing the current <i> would be best since we don't use it as it is anyway.

I don't understand the quoting rules either lol.

@enumag enumag closed this as completed Feb 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants