Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Umineko specific builds to a fork #11

Closed
drojf opened this issue Aug 13, 2022 · 1 comment
Closed

Migrate Umineko specific builds to a fork #11

drojf opened this issue Aug 13, 2022 · 1 comment

Comments

@drojf
Copy link

drojf commented Aug 13, 2022

Currently, (due to me), the releases page contains twice as many executables as normally needed, and the executables are named "umineko".

In addition, the Windows executables have an Umineko icon, which is not useful for people who just want to use the engine in an arbitrary game,

This is due to some changes to the build system I made some time ago (I guess I thought we would only use this internally for some reason), plus Olga did the icons for us.


I would fix this by forking this repository to ponscripter-fork-umineko, and hosting the Umineko specific stuff there. Also, adding a readme to explain that this repo for internal use only.

Then on this repository, reverting any changes I made to the build system, and reverting the icon change.

@drojf drojf mentioned this issue Dec 10, 2022
@drojf
Copy link
Author

drojf commented Dec 11, 2022

I've implemented this in 97e597d and 4ef9aa3

umineko executables will now be hosted at https://github.com/07th-mod/ponscripter-umineko (I haven't set this up properly yet).

Also, the installer no longer downloads from this repo, it downloads from https://github.com/07th-mod/ponscripter-umineko, so we can release executables in any format/naming scheme without breaking things.

@drojf drojf closed this as completed Dec 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant