Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewards for file upload should be rounded up to 64Kb chunks. #1816

Closed
Sriep opened this issue Nov 20, 2022 · 0 comments · Fixed by #2130
Closed

Rewards for file upload should be rounded up to 64Kb chunks. #1816

Sriep opened this issue Nov 20, 2022 · 0 comments · Fixed by #2130
Assignees

Comments

@Sriep
Copy link
Contributor

Sriep commented Nov 20, 2022

Currently, we can have file uploads of around 1KB that are too small to trigger a payment. Hence rewards for file upload should be rounded up to 64Kb chunks.

commitBlobberConnection should have the size field in the input WriteMarker converted to multiples of 64KB.

Positive values of size round up to the next multiple of 64KB, negative values round down to the previous multiple of 64KB.

Return an error if the size is zero. Might need to confirm there is no valid reason for a zero size.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants