Add the ability to make the application fullscreen and borderless on MS. #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0intro
force-pushed
the
master
branch
2 times, most recently
from
002b62c
to
279e133
Compare
|
I've tested on Windows 7 and your change seems to work fine. I've squashed the two commits, edited the subject, did some aesthetic adjustments (like using /* */ instead of //) and merged your PR. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows, I got mildly annoyed by the full-screened application still having a title bar at the top. So, I added the ability to hit 'F11' in order to have the application lose its title bar and fullscreen (similar to the behavior of web browsers and F11). Hitting F11 again returns the screen to being a normal titled window.
Here's a gif of the behavior: https://gfycat.com/DishonestFaroffFlee
I figured it might be appreciated by the other person who uses drawterm on Windows.