Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

readFragment leaks "any" when used without generic & explicit fragment. #215

Closed
3 tasks done
ariesclark opened this issue Apr 16, 2024 · 1 comment · Fixed by #216
Closed
3 tasks done

readFragment leaks "any" when used without generic & explicit fragment. #215

ariesclark opened this issue Apr 16, 2024 · 1 comment · Fixed by #216

Comments

@ariesclark
Copy link

Describe the bug

declare const value: FragmentOf<...>
readFragment(value) // any.

Reproduction

No response

gql.tada version

1.5.1

Validations

  • I can confirm that this is a bug report, and not a feature request, RFC, question, or discussion, for which GitHub Discussions should be used
  • Read the docs.
  • Follow our Code of Conduct
@kitten kitten mentioned this issue Apr 16, 2024
Merged
@kitten
Copy link
Member

kitten commented Apr 16, 2024

Nice catch! As far as I can tell, this should be a really simple and clean fix. PR is linked

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Prevent readFragment from falling back to any return types 0no-co/gql.tada
2 participants
@kitten @ariesclark