Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use clap to parse command arguments #2

Merged
merged 5 commits into from Feb 10, 2024
Merged

Use clap to parse command arguments #2

merged 5 commits into from Feb 10, 2024

Conversation

DrChat
Copy link
Contributor

@DrChat DrChat commented Feb 9, 2024

Makes for a nicer end-user experience :)

kd> !snapshot --help
[snapshot] Usage: snapshot <KIND> [STATE_PATH]

Arguments:
  <KIND>        The kind of snapshot to take [possible values: active-kernel, full]
  [STATE_PATH]  The path to save the snapshot to

Options:
  -h, --help  Print help

@0vercl0k
Copy link
Owner

This is awesome - thank you for sending this over! I just made nits changes - let me know if they look good to you and will merge this in :)

Also, TIL the #[default] attribute on the Enum which is super handy; cheers for sharing!

Cheers

@DrChat
Copy link
Contributor Author

DrChat commented Feb 10, 2024

Thanks! And thanks for making this, this is great.
I'll probably look to push some more functionality in future PRs like wrappers for more WinDbg interfaces.

src/lib.rs Outdated Show resolved Hide resolved
@DrChat
Copy link
Contributor Author

DrChat commented Feb 10, 2024

I'm good with the changes btw - feel free to send it :)

@0vercl0k
Copy link
Owner

Awesome - thanks for taking a look! And yes happy to merge improvements in 🚀

Cheers

@0vercl0k 0vercl0k merged commit e28bc4f into 0vercl0k:main Feb 10, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants