Adding new optional utility properties #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plauche
changed the title
|
Hey @plauche I know this PR has been here for more than a month. Had multiple production releases within the last 30 days at my work. So sorry for missing this. This is tested with multiple cases, right? Can I take your word for it? I don't want to block this PR anymore because of my time constraints. Let me know if this can be merged. I'll merge it right away. And a million thanks for taking your time and improving this library. |
|
Hello passing customMediaStream is handy, any chance this pull request be revived |
Rutulpatel7077
approved these changes
Jul 4, 2021
|
Please let's take care of this - customMediaStream is important! |
|
I've resurrected this w/ the latest master in #92 |
DeltaCircuit
pushed a commit
that referenced
this pull request
Apr 12, 2022
* Adding optional deviceId prop * Including lib * Adding more broad customMediaStream prop * Added stopStreamsOnStop prop to prevent stopping underlying streams when recording stops * Added onStart hook * Removing deviceId prop in favor of customMediaStream Co-authored-by: Ryan Plauche <ryan.plauche@conduit.vc>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ended up expanding this PR into three new optional properties:
onStart- A function similar toonStopallowing for custom behavior when recording starts.customMediaStream- Instead of just passing in adeviceIdI opted to allow the user to pass in their ownMediaStreamfor total control over what is recorded.stopStreamsOnStop- The current default behavior is to stop the media streams when the recording stops. This flag preservers that behavior, but also allows the option to not stop streams when recording stops.