You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
After using hfsfuse to transfer some files from an HFS+ drive with rsync, I noticed that running ls on some symlinks shows random bytes appearing, appended at the end of the actual destination. For example:
$ ls -la 'node_modules/puppeteer/.local-chromium/mac-869685/chrome-mac/Chromium.app/Contents/Frameworks/Chromium Framework.framework/Versions/'
total 4
drwxr-xr-x 1 99 99 36 May 11 2021 .
drwxr-xr-x 1 99 99 158 May 11 2021 ..
drwxr-xr-x 1 99 99 142 May 11 2021 91.0.4469.0
lrwxrwxrwx 1 99 99 14 May 11 2021 Current -> '91.0.4469.0'$'\324\374\177'
A few more examples can be seen in this rsync output from when I was copying from the HFS+ drive:
Strangely, after remounting, the issue sometimes goes away when using ls -la to see what the symlinks point to, but re-running rsync shows that rsync is detecting differnces in what the symlinks point to:
This seems like it might be a reading out-of-bounds type of issue - maybe somewhere in the code it reads outside the string or doesn't put a null terminator early enough. Where could this problem be in the code - maybe where link resolution happens like in hfsfuse_readlink or hfsfuse_opendir?
The text was updated successfully, but these errors were encountered:
Hi, thanks a lot for opening this. I pushed a fix to master just now at 529cb8b which resolves it. I'll publish a release with this shortly. Let me know if you try this out and run into any issues.
Hello,
After using hfsfuse to transfer some files from an HFS+ drive with rsync, I noticed that running ls on some symlinks shows random bytes appearing, appended at the end of the actual destination. For example:
A few more examples can be seen in this rsync output from when I was copying from the HFS+ drive:
Strangely, after remounting, the issue sometimes goes away when using
ls -la
to see what the symlinks point to, but re-running rsync shows that rsync is detecting differnces in what the symlinks point to:This seems like it might be a reading out-of-bounds type of issue - maybe somewhere in the code it reads outside the string or doesn't put a null terminator early enough. Where could this problem be in the code - maybe where link resolution happens like in
hfsfuse_readlink
orhfsfuse_opendir
?The text was updated successfully, but these errors were encountered: