Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

not skipping ads #84

Closed
RWitteBusje023 opened this issue Nov 8, 2023 · 19 comments
Closed

not skipping ads #84

RWitteBusje023 opened this issue Nov 8, 2023 · 19 comments

Comments

@RWitteBusje023
Copy link

Hi, its not skipping ads for me anymore, already reinstalled but stuck at 74 ads skipped.
@0x48piraj
Copy link
Owner

Thank you for providing the details @RWitteBusje023. can you dump the current DOM state so I can examine it closely? (it's working for me as well as the majority as of now)

How to?

When FadBlock doesn't work on a specific ad, while the ad is showing, pause the ad, then using the Web Inspector (F12), go to the Elements tab, right-click on the <html> tag in your code, and select Copy->Copy outerHTML. Then paste that into a new file and save.

@RWitteBusje023
Copy link
Author

Hi, its not a specific ad that's not being skipped, none of the ads are getting skipped.

@0x48piraj
Copy link
Owner

Just pick an ad, and do the following so I can analyze the issue because it's working fine for me. YouTube likes to test new patches with certain users and locations so without reports I can't do much until it's globally applied.

@Farseer123456789
Copy link

I purchased the premium version of the extension and it's stopped blocking ads at 107 ads blocked

@0x48piraj
Copy link
Owner

0x48piraj commented Nov 8, 2023 •
edited
Loading

Thank you for providing the details @Farseer123456789. can you dump the current DOM state so I can examine it closely? (it's working for me as well as the majority as of now)

How to?

When FadBlock doesn't work on a specific ad, while the ad is showing, pause the ad, then using the Web Inspector (F12), go to the Elements tab, right-click on the <html> tag in your code, and select Copy->Copy outerHTML. Then paste that into a new file and save.

Edit: It's late in my timezone and I have been working all day on the project. I will look into the issue with a fresh set of eyes. Anyone who finds this issue, please dump the DOM so I can investigate and quickly release a patch.

@BouquetofDiamonds
Copy link

No longer skipping ads on videos for me, either. It was working perfectly fine until today. However, every time I try to dump the dom to help, my tab freezes. Maybe it's just my Chromebook.

@Farseer123456789
Copy link

Thank you for providing the details @Farseer123456789. can you dump the current DOM state so I can examine it closely? (it's working for me as well as the majority as of now)

How to?

When FadBlock doesn't work on a specific ad, while the ad is showing, pause the ad, then using the Web Inspector (F12), go to the Elements tab, right-click on the <html> tag in your code, and select Copy->Copy outerHTML. Then paste that into a new file and save.

Edit: It's late in my timezone and I have been working all day on the project. I will look into the issue with a fresh set of eyes. Anyone who finds this issue, please dump the DOM so I can investigate and quickly release a patch.

I'm sorry but I have no idea how to do that

@0x48piraj
Copy link
Owner

@BouquetofDiamonds seems like it's a similar case to #85. I am fried for today, I will look into the issue tomorrow, hopefully till then the new version will drop freeing me to work on these new issues.

@BouquetofDiamonds
Copy link

BouquetofDiamonds commented Nov 8, 2023 via email

@TheNamor
Copy link

TheNamor commented Nov 8, 2023

In case not I have an example ad that was not caught.
example_ad.txt

@YoukaiTheGit
Copy link

YoukaiTheGit commented Nov 9, 2023 •
edited
Loading

Another example of an ad in the middle of a video:
ad.txt
Extension version 2.2 (Nov 7, 2023)
Firefox 119.0

@YoukaiTheGit
Copy link

YoukaiTheGit commented Nov 9, 2023 •
edited
Loading

Capture of the DOM before (while main video is playing), during, and after an ad:
video-before.txt
ad1.txt
video-after.txt

During the ad, the #movie_player element gets the class 'ad-showing', and the video element's src blob changes.

@0x48piraj
Copy link
Owner

Doesn't seem like any DOM elements changes (ad.txt). Yes, the ad-showing and ad-interrupting classes are known to enter at the time of an ad.

If you're using Firefox, there can be a lot of compatibility issues as Firefox has inbuilt protection module called "Enhanced protection".

If you use Chrome, and can reproduce the bug, can you go to chrome://extensions and see if FadBlock has registered any errors, and if it has, can you click on the Errors button and post the screenshot?

@0x48piraj 0x48piraj mentioned this issue Nov 9, 2023
Open
@kwongtn
Copy link

kwongtn commented Nov 9, 2023

Facing same issue, here are the files
ad2.txt
ad1.txt
post_ad.txt

Can't find logs though, am using

  • Microsoft Edge for Business Version 118.0.2088.69 (Official build) (64-bit)
  • Fadblock 2.1

@0x48piraj
Copy link
Owner

I have seen some reports where YouTube is banning individuals who were caught using uBlock or any traditional adblockers. Can you switch an account and test again?

@YoukaiTheGit
Copy link

I switched to Chrome, signed into Youtube with the same account, but could not reproduce the problem. fadblock worked as expected there. However, the extension version is 2.1. In Firefox (which wasn't skipping ads), it is 2.2

@Letiz0
Copy link

Letiz0 commented Nov 10, 2023 •
edited
Loading

pausingAd.txt

I found they remove the node with .ytp-ad-preview-text class, is that the reason why it doesnt work anymore?
src

null1
null2
null3

@RWitteBusje023
Copy link
Author

Hello, sorry for late response, here is a copy of the html.
ad.txt

@0x48piraj
Copy link
Owner

The new version (2.5) is out on Chrome! LFG!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@0x48piraj @kwongtn @TheNamor @YoukaiTheGit @Letiz0 @RWitteBusje023 @Farseer123456789 @BouquetofDiamonds