Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supporting nextcloud instances installed in subdirectories #7

Merged
merged 1 commit into from
Aug 1, 2021

Conversation

penguin86
Copy link

Hello Andrewerr! Thank you very much for this app, I'm using an AOSP rom without google services and I was without notifications for moths before discovering your app!
Unfortunately, it seems not to work with nextcloud instances installed in subdirectories like mine (e.g. https://my.host/nextcloud) because the whole "my.host/nextcloud" string was sent in the Host header.
I made a little fix, I hope it will be useful to someone else.
I also removed the "https://" part of the url in case someone dumb like me ( XD ) writes the complete URL.
Have a nice day!

@0xf104a
Copy link
Owner

0xf104a commented Aug 1, 2021

Hello.
Thank you very much for solving this issues. I will slightly change your code to match with what I promised in issue #5, so a switch for using insecure connection will be added.
Have a nice day too :)

@0xf104a 0xf104a merged commit eaf2b8f into 0xf104a:main Aug 1, 2021
@0xf104a 0xf104a mentioned this pull request Aug 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants