Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👷 create CI workflow for test-coverage #37

Merged
merged 3 commits into from
Jul 28, 2023
Merged

👷 create CI workflow for test-coverage #37

merged 3 commits into from
Jul 28, 2023

Conversation

qd-qd
Copy link
Member

@qd-qd qd-qd commented Jul 28, 2023

This new workflow run the test-coverage script. The coverage is posted
as a comment on the PR. The workflow is configured to succeed if the
coverage is above 80%.
The internal precompile variant is excluded from the coverage report as
it is highly experimental and not expected to be used, even in dev mode,
at this point

Fixes #17

This test is a minimal regression, it must be improved in the future!
@qd-qd qd-qd self-assigned this Jul 28, 2023
@github-actions
Copy link

github-actions bot commented Jul 28, 2023

Changes to gas cost

Generated at commit: 1f5b1be26572b419d5dd2483dae7d107ee12b1b0, compared to commit: 482ce7b8d2ecafb50a8b19cd58aae56b392f50de

🧾 Summary (20% most significant diffs)

Contract Method Avg (+/-) %
ImplementationECDSA zzAddN +150 ❌ +22.69%

Full diff report 👇
Contract Deployment Cost (+/-) Method Min (+/-) % Avg (+/-) % Median (+/-) % Max (+/-) % # Calls (+/-)
ImplementationECDSA 543,575 (0) zzAddN 661 (0) 0.00% 811 (+150) +22.69% 811 (+150) +22.69% 961 (+300) +45.39% 2 (+1)

@qd-qd qd-qd force-pushed the test-coverage branch 2 times, most recently from 8ff42d6 to 22d6a1c Compare July 28, 2023 10:16
This new workflow run the test-coverage script. The coverage is posted
as a comment on the PR. The workflow is configured to succeed if the
coverage is above 80%.
The internal precompile variant is excluded from the coverage report as
it is highly experimental and not expected to be used, even in dev mode,
at this point
@github-actions
Copy link

github-actions bot commented Jul 28, 2023

LCOV of commit 587a214 during Tests #169

Summary coverage rate:
  lines......: 90.3% (84 of 93 lines)
  functions..: 100.0% (9 of 9 functions)
  branches...: no data found

Files changed coverage rate: n/a

@qd-qd qd-qd merged commit 587a214 into main Jul 28, 2023
5 checks passed
@qd-qd qd-qd deleted the test-coverage branch July 28, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Fix coverage reporting of the ECDSA library
1 participant