Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v0.23 broke blocky blocking disable #1336

Closed
rahilarious opened this issue Jan 14, 2024 · 2 comments · Fixed by #1373
Closed

v0.23 broke blocky blocking disable #1336

rahilarious opened this issue Jan 14, 2024 · 2 comments · Fixed by #1373
Assignees
@BenMcH
Labels
🐞 bug Something isn't working
Milestone
v0.24

Comments

@rahilarious
Copy link
Contributor

rahilarious commented Jan 14, 2024 •
edited
Loading

when I ran blocky blocking disable

blocky 0.22 responded:

[2024-02-10 02:55:02] INFO OK

blocky 0.23 responds:

Error: response NOK, 400 Bad Request group '' is unknown

works totally fine in 0.23 when I run curl localhost:4000/api/blocking/disable

CC: @ThinkChaos @0xERR0R @BenMcH
@rahilarious rahilarious changed the title Allow to disable blocking for all groups [0.23] Bring back ability to disable blocking for all groups Feb 10, 2024
@BenMcH BenMcH mentioned this issue Feb 10, 2024
Merged
@BenMcH
Copy link
Contributor

BenMcH commented Feb 10, 2024

I found the issue buried in quite a large PR from September 😄 PR is up and should be able to be reviewed by a maintainer when they have the time 🚀

@rahilarious
Copy link
Contributor Author

I found the issue buried in quite a large PR from September 😄 PR is up and should be able to be reviewed by a maintainer when they have the time 🚀

whoa, that was quick! Thank you. Hopefully will be merged soon

@ThinkChaos ThinkChaos added the 🐞 bug Something isn't working label Feb 10, 2024
@ThinkChaos ThinkChaos added this to the v0.24 milestone Feb 10, 2024
@ThinkChaos ThinkChaos changed the title [0.23] Bring back ability to disable blocking for all groups v0.23 broke blocky blocking disable Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BenMcH BenMcH

Labels
🐞 bug Something isn't working
Projects
None yet
Milestone
v0.24
Development

Successfully merging a pull request may close this issue.

fix: Corrects ability to disable all blocking from the CLI by not providing any groups BenMcH/blocky
3 participants
@BenMcH @ThinkChaos @rahilarious