Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Query logging type InfluxDB #626

Closed
kwitsch opened this issue Aug 6, 2022 · 3 comments
Closed

[Feature Request] Query logging type InfluxDB #626

kwitsch opened this issue Aug 6, 2022 · 3 comments

Comments

@kwitsch
Copy link
Collaborator

kwitsch commented Aug 6, 2022

Add additional query logging type InfluxDB.
To reduce stress on the DB endpoint log entries should be submitted in batches.

@kwitsch kwitsch closed this as not planned Won't fix, can't repro, duplicate, stale Aug 21, 2022
@kwitsch
Copy link
Collaborator Author

kwitsch commented Aug 21, 2022

Closed in favor of log to redis.

@0xERR0R
Copy link
Owner

0xERR0R commented Aug 21, 2022

I think, you mean #632? If yes, redis is currently used to hold the cache and not for query logging

@kwitsch
Copy link
Collaborator Author

kwitsch commented Aug 22, 2022

@0xERR0R

As redis has an per entry timeout similar to InfluxDB there is no cleanup routine necessary.
Simply add the entry timeout to the log entry and redis cleanup on its own(much like the cache TTL).
I would simply add a logging type redis which checks if redis is configured and writes the logs to it.
In my opinion it is a bit redundant for users who already use redis to spin up a second database for logging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants