Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review need for executor #1745

Closed
3 tasks
arnaubennassar opened this issue Mar 3, 2023 · 2 comments
Closed
3 tasks

Review need for executor #1745

arnaubennassar opened this issue Mar 3, 2023 · 2 comments
Labels
aggregator eth tx manager improvement l2 gas pricer

Comments

@arnaubennassar
Copy link
Member

The following components shouldn't need executor:

  • AGGREGATOR
  • ETHTXMANAGER
  • L2GASPRICER

We need to review if this components can start without executor
@tclemos
Copy link
Contributor

tclemos commented Mar 4, 2023

Any component that depends on the State, will depend on the Executor automatically.
Also, the State only allows the component to start after it connects to the Executor, if it does not connect, it breaks the component execution.

In order to allow components to access the State without having to depend on the Executor, we need to make it optional during the State initialization and double-check it in all the Executor calls, providing a specific error for this problem, similar to the work we did in the Etherman working as read-only.

@ToniRamirezM
Copy link
Contributor

Implemented in PR #1995

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
aggregator eth tx manager improvement l2 gas pricer
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tclemos @arnaubennassar @ToniRamirezM