Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support 0x00 as a valid hash in JSON RPC #1791

Closed
arnaubennassar opened this issue Mar 9, 2023 · 0 comments · Fixed by #1792
Closed

Support 0x00 as a valid hash in JSON RPC #1791

arnaubennassar opened this issue Mar 9, 2023 · 0 comments · Fixed by #1792
Assignees
Labels
bug Something isn't working rpc

Comments

@arnaubennassar
Copy link
Member

arnaubennassar commented Mar 9, 2023

Example:

for the endpoint eth_getStorageAt, this should be a valid input:

{
	"jsonrpc":"2.0", 
	"method": "eth_getStorageAt", 
	"params": [
		"0xA766B25F0577EB4802e659dF0C1bc4b3C8A0fDeD", 
		"0x00",
		"latest"
	], 
	"id": 1
}

Note that now this call would return Invalid Params, but if the 0x00 is changed to 0x0000000000000000000000000000000000000000000000000000000000000000, then the request is valid. This could affect any other endpoint that has a input param that is a hash

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working rpc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants