JSONValue type is overly wide

[nedgar]

The type definition of JSONValue allows object and Array<object> (in addition to string | number | boolean) which seems overly wide.

Should it instead be: type JSONValue = string | number | boolean | JSONObject | Array<JSONObject>?

[vmidyllic]

can you suggest what are you going to achieve with such a change?
how does object work wrong for your use case?
We will have a detailed look on this problem.

[nedgar]

@vmidyllic I'm not hitting it as a real issue, since my examples using it are valid JSON, but type object allows values that aren't supported in JSON, e.g. functions.

With the current typing a function is allowed:

With the type changed (corrected from my original comment) to type JSONValue = string | number | boolean | JSONObject | Array<JSONValue>, it flags the function as invalid:

[nedgar]

Hrm, my proposed change doesn't allow interface types, dates, or other objects that implement toJSON().

Not allowing dates may be a feature, though, since they get serialized as an ISO 8601 string not as seconds from epoch.
I guess it depends what the intent is here. Do you want to allow any object that can be stringified to JSON? If not, how should it be restricted?

There's a good discussion here: microsoft/TypeScript#1897

[github-actions]

This issue is stale because it has been open for 14 days with no activity.

[vmidyllic]

@nedgar we add this task to the backlog. But it's not first priority.

[nedgar]

No worries, it's not urgent at all, thanks.

[github-actions]

This issue is stale because it has been open for 14 days with no activity.

[sanketsaagar]

Hi @nedgar , As our team has acknowledged that we have added this task to our backlog and it will be resolved, You may close the issue.

[github-actions]

This issue is stale because it has been open for 14 days with no activity.

[github-actions]

This issue was closed because it has been inactive for 7 days since being marked as stale.