Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add conditional feature support in the kernel assembly #416

Merged
merged 5 commits into from
Jul 23, 2024
Merged

feat: add conditional feature support in the kernel assembly #416

merged 5 commits into from
Jul 23, 2024
+262 −29

Conversation

Nashtare
Copy link
Collaborator

@Nashtare Nashtare commented Jul 20, 2024 •
edited
Loading

closes #409

I ended up using a more general approach to handle arbitrary chunks of code within conditional blocks (initial description in #409 was only mentioning skipping code between two global labels, not it handles arbitrary chunks).

Now anything between:

#[cfg(feature = feature_foo)]
{
    ....
}

will be ignored.

@Nashtare Nashtare added enhancement New feature or request crate: evm_arithmetization Anything related to the evm_arithmetization crate. labels Jul 20, 2024
@Nashtare Nashtare self-assigned this Jul 20, 2024
@Nashtare Nashtare requested a review from muursh as a code owner July 20, 2024 14:11
@Nashtare Nashtare added this to the System strengthening milestone Jul 21, 2024
LindaGuiga
LindaGuiga approved these changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@LindaGuiga LindaGuiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

evm_arithmetization/src/cpu/kernel/ast.rs Outdated Show resolved Hide resolved
@Nashtare Nashtare merged commit 7a29b13 into develop Jul 23, 2024
14 checks passed
@Nashtare Nashtare deleted the feat/kernel_feature branch July 23, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muursh muursh muursh approved these changes

@LindaGuiga LindaGuiga LindaGuiga approved these changes

Assignees

@Nashtare Nashtare

Labels
crate: evm_arithmetization Anything related to the evm_arithmetization crate. enhancement New feature or request
Projects
Zero EVM
Status: Done
Milestone
System strengthening
Development

Successfully merging this pull request may close these issues.

Support conditional asm code parsing in the kernel
3 participants
@Nashtare @muursh @LindaGuiga