feat: set default skip RFQt buy requests to false #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrharder
changed the title
steveklebanoff
approved these changes
May 19, 2020
|
deploy staging |
|
deploy production |
github-actions bot
pushed a commit
that referenced
this pull request
May 25, 2020
# [1.5.0](v1.4.0...v1.5.0) (2020-05-25) ### Bug Fixes * unify the response data from /swap/v0/price and /meta_transaction/v0/price ([#228](#228)) ([62f3fae](62f3fae)) ### Features * Add Prometheus Monitoring ([#222](#222)) ([5a51add](5a51add)) * added an epochs/n endpoint to get info on an arbitrary epoch ([#230](#230)) ([68ec159](68ec159)) * lower default slippage percentage to 1% ([#238](#238)) ([c7ec0ff](c7ec0ff)) * MetaTxn add signer heartbeat and status ([#236](#236)) ([3a11867](3a11867)) * set default skip RFQt buy requests to false ([#232](#232)) ([a5d7a1c](a5d7a1c))
|
🎉 This PR is included in version 1.5.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Disable skipping RFQt request where
buyAmountis specified instead of justsellAmount.Testing Instructions
Simple config change, no new tests should be required. In a test deployment, should poll RFQt servers when
buyAmountis specified inswap/quoteandswap/price.Checklist
[WIP]if necessary.