fix: Changes latency to be capped at 600ms, added some extra typing #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PirosB3
changed the title
|
yeah the removal of those params is fine. |
|
deploy staging |
|
deploy prod |
github-actions bot
pushed a commit
that referenced
this pull request
Jul 13, 2020
## [1.10.2](v1.10.1...v1.10.2) (2020-07-13) ### Bug Fixes * Changes latency to be capped at 600ms, added some extra typing ([#275](#275)) ([cd545c8](cd545c8))
|
🎉 This PR is included in version 1.10.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We noticed that RFQT latency on
api.0x.orgcan be too high at times and may cause downstream latency to our customers, so we are going to cap HTTP RFQT timeouts to 600ms. This PR sets themakerEndpointMaxResponseTimeMsparameter that can be optionally specified inRfqtRequestOpts, and that defaults to 1 second. We are intentionally enforcing this parameter to be600.skipBuyRequestsis an old relic of when our RFQT bot only supported sell requests. skipBuyRequests is not used at all by AssetSwapper, since it’s not present in RfqtRequestOpts.slippagePercentagewas removed here and passing this parameter to SwapQuoter will have no effect at all.Can I get a sign off from @dekz and/or @dorothy-zbornak that the removal of these 2 parameters does not cause any issue downstream? and that these parameters are simply technical debt?
Testing Instructions
Once I have a first approval that my PR does not introduce new issues, I will try it in staging
Checklist