Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track 'offline' notifications #106

Closed
pablofullana opened this issue Mar 7, 2019 · 1 comment
Closed

Track 'offline' notifications #106

pablofullana opened this issue Mar 7, 2019 · 1 comment
Assignees

Comments

@pablofullana
Copy link
Contributor

As a logged in user, when opening the dApp, I'd like to see notifications for all the events (relevant to myself) that occurred while I was 'offline'

@fvictorio
Copy link
Contributor

There are a lot of unknowns here:

  • What kinds of notifications are we going to show? Some that come to mind: one of your orders was filled (partially or totally), one of your orders expired, one of your orders was removed from the relayer because it became invalid (for example, you don't have enough tokens anymore).
  • How are we going to get these notifications? One option is to save in the local storage the last timestamp the relayer was checked and the last block the exchange contract was checked. With the contract we can get all events since then that involve the current address. With the relayer, I'm not so sure. Do we have some mechanism to know that an order was removed since that timestamp?

@pablofullana pablofullana added this to In progress in ERC-20 marketplace Mar 18, 2019
@fvictorio fvictorio moved this from In progress to Review in progress in ERC-20 marketplace Mar 20, 2019
@pablofullana pablofullana moved this from Review in progress to Reviewer approved in ERC-20 marketplace Mar 21, 2019
ERC-20 marketplace automation moved this from Reviewer approved to Done Mar 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants