Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "Fee" field of "Order Details" in buy/sell component (when in Limit) #58

Closed
2 tasks
fvictorio opened this issue Feb 22, 2019 · 2 comments
Closed
2 tasks

Add "Fee" field of "Order Details" in buy/sell component (when in Limit) #58

fvictorio opened this issue Feb 22, 2019 · 2 comments
Assignees
@mariano-aguero @Agupane

Comments

@fvictorio
Copy link
Contributor

Use the maker and taker fees along with the order price to compute the total fee in ETH.

After this is done, we should add some mechanism for obtaining the price of ETH in USD.

  • Show fee details in ETH
  • Show fee details in USD
@Agupane Agupane mentioned this issue Feb 26, 2019
Merged
@fvictorio fvictorio mentioned this issue Feb 27, 2019
Closed
@unjapones
Copy link
Contributor

UPDATE 07 March 2019:
Last week we spoke about this with the team and we realized that the user would probably like to see the fee in ZRX (because the will require ZRX in his/her balance, not ETH...]) + some user-friendly conversion of that fee value to USD.

@unjapones unjapones changed the title Add order details in buy/sell component Add "Fee" field of "Order Details" in buy/sell component (when in Limit) Mar 7, 2019
@unjapones
Copy link
Contributor

UPDATE 07 March 2019:
Decided to tackle the "Order Details" in 4 different issues:

  • 2 tickets to "implement Fee" and "Total Cost" in LIMIT.
  • 2 tickets for the same in MARKET.

@unjapones unjapones mentioned this issue Mar 7, 2019
Closed
@Agupane Agupane closed this as completed Mar 8, 2019
@unjapones unjapones mentioned this issue Mar 13, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mariano-aguero mariano-aguero

@Agupane Agupane

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@fvictorio @mariano-aguero @unjapones @Agupane