Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: Remove OrderExpirationBuffer config #419

Closed
fabioberger opened this issue Sep 17, 2019 · 0 comments
Closed

core: Remove OrderExpirationBuffer config #419

fabioberger opened this issue Sep 17, 2019 · 0 comments

Comments

@fabioberger
Copy link
Contributor

Currently, we allow the operator to customize a buffer they'd like added to UTC time when validating an order's expiry. This buffer is applied when validating orders submitted via JSON-RPC as well as orders submitted from other peers. If peers have this set to different values, a peer with a lower buffer would consider the orders from a peer with a higher buffer invalid and penalize the peer for sharing those orders. We should either remove this configuration or alternatively, make it only apply to the JSON-RPC OrderEvents subscription, and not the validation performed when sharing orders with peers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant