[sol-cov] coverage report is incorrect

[ewingrj]

Current Behavior

I haven't investigated too closely, however when I run code coverage, the generated report is incorrect.

As you can see in the img below, line 111 has been covered, but 110 has not. In reality, lines 110 - 115 should all be covered

Steps to Reproduce (for bugs)

The above report was generated using the current sol-cov v2-prototype branch with PR #702 commit here

you can find instructions to reproduce here

[LogvinovLeon]

I'm able to repro that and I'm researching the cause. Thanks for detailed repro instructions

[LogvinovLeon]

Ok, got it. We currently don't support creating contracts from within contracts. When we encounter that situation - we just stop parsing that trace and return partial data that we have so far. That's why coverage is broken. I think we should ignore that trace altogether for now. We will properly fix that later when we do support contract creations. I understand that this is a critical use-case for you and you need it. Unfortunately, now we're mostly focused on v2 of the 0x protocol. If you want - you can contribute. I can give you the guidance. Also happy to jump on the call. If you're willing to wait - I hope to get to it in the next 2-3 weeks.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[stale]

This issue has been automatically closed because no activity occured in 7 days after being marked as stale. If it's still relevant - feel free to reopen. Thank you for your contributions.