This repository has been archived by the owner on Jul 9, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 465
[SoHoAudit] Combined taker fees exceeding MAX_INT will revert execution rather than successfully process MixinMatchOrders.sol#281-284: #853
Comments
This should actually never happen since the total supply of ZRX is only 10^27 :) |
This was referenced Jan 9, 2023
This was referenced Jan 10, 2023
This was referenced Nov 25, 2023
This was referenced May 13, 2024
This was referenced May 14, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
While unlikely to occur, if an order is to be fulfilled in which the properly owed taker fees paid out to a singular party exceed MAX_INT, the process will revert rather than establish a secondary methodology by which to pay relevant taker fees to the according address.
Despite the likeliness of occurrence, this behavior should be noted and presented accordingly. Usage of
require
is suggested in order to provide justification as to why the transaction failed to complete.The text was updated successfully, but these errors were encountered: