Skip to content
This repository has been archived by the owner on Jul 9, 2021. It is now read-only.

[SoHoAudit] Combined taker fees exceeding MAX_INT will revert execution rather than successfully process MixinMatchOrders.sol#281-284: #853

Closed
0xHaas opened this issue Jul 11, 2018 · 1 comment

Comments

@0xHaas
Copy link

0xHaas commented Jul 11, 2018

While unlikely to occur, if an order is to be fulfilled in which the properly owed taker fees paid out to a singular party exceed MAX_INT, the process will revert rather than establish a secondary methodology by which to pay relevant taker fees to the according address.

Despite the likeliness of occurrence, this behavior should be noted and presented accordingly. Usage of require is suggested in order to provide justification as to why the transaction failed to complete.

@abandeali1
Copy link
Member

This should actually never happen since the total supply of ZRX is only 10^27 :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants