Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run examples in CI #385

Open
recmo opened this issue Oct 16, 2019 · 0 comments
Open

Run examples in CI #385

recmo opened this issue Oct 16, 2019 · 0 comments

Comments

@recmo
Copy link
Contributor

recmo commented Oct 16, 2019

To prevent issues like #383 from happening again, all examples should be run in the CI, similar to unit tests.

Some examples are too large to feasibly run on CI resources, for this there are two solutions:

  • Run them on external resources, like we doe with the benchmarks
  • Parameterize the size in a command line argument and run a smaller version in CI.

The second approach is probably, best, but requires the large examples to be changed to have parameterized size. This size parameter is a useful feature for benchmarking and scale testing too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant