Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store maximum uint for fully filled or cancelled orders #11

Closed
abandeali1 opened this issue Sep 18, 2017 · 0 comments
Closed

Store maximum uint for fully filled or cancelled orders #11

abandeali1 opened this issue Sep 18, 2017 · 0 comments

Comments

@abandeali1
Copy link
Member

Summary

This is a simple modification to the filled and cancelled mappings that would allow fully filled or cancelled orders to be easily detectable on-chain.

Motivation

There is currently no way to tell if an order has been fully filled or cancelled on-chain with only a reference to that order's orderHash. As is, the order takerTokenAmount must be known and verifiable (all of the order parameters must be used to verify this on-chain).

Specification

When an order is fully filled or cancelled, the maximum unsigned integer (2**256 - 1) can be stored in the corresponding filled or cancelled mappings.

Rationale

This change could enable interesting features down the line, such as conditional orders (see #9 ). Note that orders that have been both partially filled and cancelled will not be detectable using this proposal. However, it can always be used to tell if an order has not been fully filled/cancelled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants