Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not double check signatures of previously filled/cancelled orders #15

Closed
abandeali1 opened this issue Dec 14, 2017 · 1 comment
Closed

Comments

@abandeali1
Copy link
Member

Summary

Currently, if you fill (or partially fill) an order that was already filled or cancelled, the Exchange contract will re-evaluate the signature of the order. This ZEIP would remove the need to verify the signature of an already partially filled or cancelled order.

Motivation

An order that has already been partially filled or cancelled always implies that the order has been approved by the maker. Skipping signature verification would save at least 3000 gas with no additional downside.

Specification

    if (filled[orderHash] == 0 && cancelled[orderHash] == 0) {
        require(isValidSignature(...);
    }
@AusIV
Copy link

AusIV commented Dec 31, 2017

This would be incompatible with #3

As the same hash could have different signatures for different fee configurations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants