Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow fee estimation for declare and deploy transactions #220

Closed
FabijanC opened this issue Sep 23, 2022 · 1 comment · Fixed by #293
Closed

Allow fee estimation for declare and deploy transactions #220

FabijanC opened this issue Sep 23, 2022 · 1 comment · Fixed by #293
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@FabijanC
Copy link
Collaborator

FabijanC commented Sep 23, 2022

Currently new classes can be declared with a supplied max fee. But a fee cannot be estimated:

account.declare(contractFactory, { maxFee: ... });

This is how we do it for invokes:

const feeEstimation = account.estimateFee(contract, "foo", { arg1: ... });
account.invoke(contract, "foo", { arg1: ... }, { maxFee: ... });

Could look like:

account.estimateDeclareFee(contractFactory, ...);
account.estimateDeployFee(contractFactory, ...);
@FabijanC FabijanC added enhancement New feature or request help wanted Extra attention is needed labels Sep 23, 2022
@ivpavici ivpavici added the OnlyDust Open for OnlyDust contributors label Dec 14, 2022
@FabijanC FabijanC changed the title Allow fee estimation for declare transactions Allow fee estimation for declare and deploy transactions Dec 19, 2022
@FabijanC
Copy link
Collaborator Author

FabijanC commented Dec 19, 2022

Also: do the estimation implicitly (can we just copy the workflow from invoking?)

@FabijanC FabijanC removed the OnlyDust Open for OnlyDust contributors label Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants