Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Good practices: Do not automatically add env vars to .profile #48

Closed
Zeioth opened this issue Mar 19, 2023 · 1 comment
Closed

Good practices: Do not automatically add env vars to .profile #48

Zeioth opened this issue Mar 19, 2023 · 1 comment

Comments

@Zeioth
Copy link

Zeioth commented Mar 19, 2023

It is ok to ask the user to define the env vars, but it is a bad idea to touch the .profile file ourselves from the installer.

@0xacx
Copy link
Owner

0xacx commented Mar 20, 2023

I agree, it is a bit invasive but I think that users who care about it, would not use the installer anyway and just install the script manually. But, for users that don't know where their shell profile is and how to edit it, the script is very useful. I added a question before editing the shell profile, so it is crystal clear to anyone what happens when running the install script. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants