Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure Travis fails fast #46

Open
0xazure opened this issue Dec 28, 2018 · 2 comments
Open

Ensure Travis fails fast #46

0xazure opened this issue Dec 28, 2018 · 2 comments
Labels
bug 🐛 Something isn't working

Comments

@0xazure
Copy link
Owner

0xazure commented Dec 28, 2018

In reviewing #34, I noticed one of the build jobs failed the clippy step but continued on to the test and build steps anyways. This seems like needless work, and it might be more desirable to tighten up the builds feedback on PRs so the build fails immediately if one of the checks like clippy or rustfmt fails.

@seanprashad does Travis not fail-fast, or do we need to configure something else? We already have fast_finish enabled in our config:

fast_finish: true

@0xazure 0xazure added the bug 🐛 Something isn't working label Dec 28, 2018
@biskit1
Copy link

biskit1 commented Dec 30, 2018

is it related to the fact that we allow failures for rust: nightly so all the tests against the nightly channel will still resume?

@0xazure
Copy link
Owner Author

0xazure commented Dec 30, 2018

No, the allow_failures for nightly means that the nightly job in the build matrix can fail but the entire build won't fail and e.g. merging a pull request won't be blocked. See: Rows that are Allowed to Fail.

Also, the specific job I linked to there is for the stable release channel, so it isn't affected by allowing failures for nightly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants