Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed for query update needed, June 2021 Google update #539

Closed
wants to merge 1 commit into from
Closed

Changed for query update needed, June 2021 Google update #539

wants to merge 1 commit into from

Conversation

ryanfrancesconi
Copy link

        NSDictionary *query = @{ @"video_id": self.videoIdentifier,
                                 @"hl": self.languageIdentifier,
                                 @"el": eventLabel,
                                 @"ps": @"default",
                                 @"html5" : @"1",
                                 @"eurl": [@"https://youtube.googleapis.com/v/" stringByAppendingString: self.videoIdentifier],
                                 @"c": @"TVHTML5",
                                 @"cver": @"6.20180913"};

@ryanfrancesconi
Copy link
Author

yet another PR for this problem. not sure why CI fails as the change is minor.

@cyb3rsalih
Copy link

though, works now?

@cyb3rsalih
Copy link

cyb3rsalih commented Jul 1, 2021

Quick fix:
Change the row in pods
pod 'XCDYouTubeKit', '~> 2.8'
to
pod 'XCDYouTubeKit', git: 'https://github.com/ryanfrancesconi/XCDYouTubeKit', branch: 'add', submodules: true

and $pod update to terminal in app/ios directory

@ryanfrancesconi
Copy link
Author

though, works now?

yes it does work with the change above!

@ryanfrancesconi
Copy link
Author

Quick fix:
Change the row in pods
pod 'XCDYouTubeKit', '~> 2.8'
to
pod 'XCDYouTubeKit', git: 'https://github.com/ryanfrancesconi/XCDYouTubeKit', branch: 'add', submodules: true

and $pod update to terminal in app/ios directory

@cyb3rsalih if you use pods... Pointing at my subbranch isn't really a long term fix.

Ideally the repository owner @0xced would merge the PR and allow everyone to keep using the framework from the correct git url, but perhaps they are offline for sometime.

@cyb3rsalih
Copy link

@ryanfrancesconi I know, its just a quick fix 🙃

@ryanfrancesconi
Copy link
Author

@0xced Appears there is something wrong with the CircleCI setup which is throwing errors. I'm not a user of that and not interested to open my account to that service, so I don't know why - but that's why all the PRs are failing...

@Nyl000
Copy link

Nyl000 commented Jul 12, 2021

Hi, can you resolve this PR issue and merge it please ? Forking and adapting the pod file with another git repo is not a good solution for maintainability.

@rbrand21
Copy link

This appears to be broken again. Pointed my podfile at your branch: pod 'XCDYouTubeKit', git: 'git@github.com:ryanfrancesconi/XCDYouTubeKit.git', branch: 'add' and getting the same error:

2021-07-23 17:20:17.964818-0700 Renegade Rehab[7294:2399174] [XCDYouTubeKit] Video operation finished with error: The operation couldn’t be completed. (XCDYouTubeVideoErrorDomain error -3.) Domain: XCDYouTubeVideoErrorDomain Code: -3

@ryanfrancesconi
Copy link
Author

@rbrand21 yes, it does appear they broke it yet again. Seems likely this approach is nearing the end of its usefulness.

@rbrand21
Copy link

@ryanfrancesconi Any suggestions? Including new plugin suggestions...lol

@ryanfrancesconi
Copy link
Author

@rbrand21 i need to look into this myself... so we'll see. given it's against the you tube terms of service, i assume this framework has given up.

@cyb3rsalih
Copy link

It starts to work again :)

@ryanfrancesconi
Copy link
Author

It starts to work again :)

it does?

@cyb3rsalih
Copy link

cyb3rsalih commented Aug 3, 2021

that time it was working. now starts to crash again. I am trying to shift iframe mode which is official

@devDWI
Copy link

devDWI commented Aug 4, 2021

Any idea?

@shadyshrif
Copy link

I think this issue is coming again

@haroonakram
Copy link

any solution for this?

@rbrand21
Copy link

rbrand21 commented Apr 7, 2022

any solution for this?

I ditched this plugin and went for opening youtube videos in a web browser which defaults to using the youtube app on the phone, if installed.
I had so many problems with this plugin over the last couple years. It was wonderful finally ripping it out.
There's now an app switch to YT but I didn't find it that disruptive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants