Quiet #warnings in XCDYouTubePlayerScript.h

[anasb]

Hi,

It would be nice to quiet down the 2 warnings in XCDYouTubePlayerScript.h:10-14, and perhaps replace them by #pragma mark.

#if defined(__IPHONE_OS_VERSION_MIN_REQUIRED) && __IPHONE_OS_VERSION_MIN_REQUIRED >= __IPHONE_7_0
#warning Rewrite JavaScriptCore code with JSContext + JSValue (available since iOS 7) instead the verbose C API.
#elif defined(__MAC_OS_X_VERSION_MIN_REQUIRED) && __MAC_OS_X_VERSION_MIN_REQUIRED >= __MAC_10_9
#warning Rewrite JavaScriptCore code with JSContext + JSValue (available since OS X 10.9) instead the verbose C API.
#endif

Thank you for this great tool !

[0xced]

If I remove the warning, then I will inevitably forget to update the code to the new JavaScriptCore API when dropping support for iOS 5 and 6.

But I have a solution for you anyway. If you are integrating XCDYouTubeKit manually, you should not drag and drop the source code in your own project but use an Xcode workspace and use the XCDYouTubeKit iOS or XCDYouTubeKit OS X target, exactly like the demo project does. Since they have their deployment targets set to iOS 5.0 and OS X 10.7 they won’t produce any warnings.

If you are integrating with CocoaPods, you can add this line in your Podfile and all the warnings will disappear:

inhibit_all_warnings!

[anasb]

Thank you for your answer.

I actually use :inhibit_warnings => true just for this pod, but I usually don't like to do so. I prefer knowing when it generates warnings to make sure nothing might be unstable. No worries though :) Thanks!

[0xced]

Hehe, I’m going to blame CocoaPods on that one. I have specified s.ios.deployment_target = "5.0" in the podspec but the generated Pods-XCDYouTubeKit target of the Pods project has a deployment target equal to what is specified in the Podfile instead of what I specified in the podspec.

I’m going to discuss this issue with the CocoaPods team but in the meantime your solution to use :inhibit_warnings => true just for this pod is a good workaround.

Also, rest assured that I take warnings very seriously, the XCDYouTubeKit project has the -Werror flag which turn warnings into errors so that I can’t even compile the project as soon as a waring appear.

[0xced]

These warnings are gone as of version 2.3.0. The XCDYouTubePlayerScript class has been rewritten with the JavaScriptCore Objective-C API.