Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Card draw animation plays on initial hand #133

Open
norswap opened this issue Mar 5, 2024 · 5 comments
Open

Card draw animation plays on initial hand #133

norswap opened this issue Mar 5, 2024 · 5 comments
Assignees

Comments

@norswap
Copy link
Member

norswap commented Mar 5, 2024

We have an animation that scrolls the hand to the latest card drawn and highlights it.

Currently this also occurs when entering the game for the first time, which is not intended (as all cards are newly drawn, highlighting the last one doesn't make sense).

@Xaxxoo
Copy link

Xaxxoo commented Mar 14, 2024

Hi @norswap, I am interested in this.

@norswap
Copy link
Member Author

norswap commented Mar 15, 2024

Hey, you need to check in with @ultraviolet10 to see if he hasn't tackled this yet. He will be touching that part of the codebase, so it's important to coordinate with him regardless — it might be better to leave him to it, but he will weigh in himself!

@ultraviolet10
Copy link
Collaborator

Hi @Xaxxoo I've just fixed this in a local branch, will push this to a PR soon (alongwith some other fixes) :)

@Joy-Adah
Copy link

Joy-Adah commented May 7, 2024

Hi @norswap is this still available?

@norswap
Copy link
Member Author

norswap commented May 14, 2024

No, as you see above, @ultraviolet10 has fixed it.
@ultraviolet10 What PR is this in?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants