Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect implementation of parse_u32div for u32div and u32div.b operations #94

Closed
grjte opened this issue Feb 2, 2022 · 1 comment
Closed

Incorrect implementation of parse_u32div for u32div and u32div.b operations #94

grjte opened this issue Feb 2, 2022 · 1 comment
Assignees
@Overcastan
Labels
assembly Related to Miden assembly bug Something isn't working good first issue Good for newcomers

Comments

@grjte
Copy link
Collaborator

grjte commented Feb 2, 2022 •
edited

The implementation of parse_u32div in the assembly u32 ops parser currently has 2 errors:

  1. The parser accepts a parameter of 0 (u32div.0), which means that the operation fails during execution instead of during compilation.
  2. The parser asserts in handle_arithmetic_operation that the top element after the processor's U32DIV op should be zero, which means that all divisions with non-zero remainder fail.
@grjte grjte mentioned this issue Feb 2, 2022
Merged
@bobbinth bobbinth added assembly Related to Miden assembly bug Something isn't working good first issue Good for newcomers labels Feb 3, 2022
Overcastan referenced this issue in Overcastan/miden Feb 25, 2022
@Overcastan
Incorrect implementation of parse_u32div for u32div and u32div.b oper…
8b0783f 
…ations maticnetwork#94
bobbinth added a commit that referenced this issue Mar 1, 2022
@bobbinth
Merge pull request #127 from Overcastan/solution_optimization
1de32d0 
Incorrect implementation of parse_u32div for u32div and u32div.b operations #94
@bobbinth
Copy link
Contributor

bobbinth commented Mar 1, 2022

Fixed by #127

@bobbinth bobbinth closed this as completed Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Overcastan Overcastan

Labels
assembly Related to Miden assembly bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Overcastan @bobbinth @grjte