Skip to content
This repository has been archived by the owner on Jul 9, 2021. It is now read-only.

OrderFillOrKillRequest and OrderFillRequest use different interface #186

Closed
apackin opened this issue Oct 10, 2017 · 1 comment
Closed

Comments

@apackin
Copy link
Contributor

apackin commented Oct 10, 2017

Is there are a reason these interfaces need to be different? I think it would make more sense if we stick to either fillTakerAmount or takerTokenFillAmount for both of these interfaces

Interface OrderFillOrKillRequest
{
	fillTakerAmount: BigNumber,
	signedOrder: SignedOrder,
}
Interface OrderFillRequest
{
	signedOrder: SignedOrder,
	takerTokenFillAmount: BigNumber,
}
@apackin apackin changed the title Interface for OrderFillOrKillRequest and OrderFillRequest use different interface OrderFillOrKillRequest and OrderFillRequest use different interface Oct 10, 2017
@fabioberger
Copy link
Contributor

Yup, that's an oversight. Let's standardize around takerTokenFillAmount.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants