Skip to content
This repository has been archived by the owner on Jul 9, 2021. It is now read-only.

Instant revamp bake-off #2704

Closed
mintcloud opened this issue Sep 11, 2020 · 23 comments
Closed

Instant revamp bake-off #2704

mintcloud opened this issue Sep 11, 2020 · 23 comments
Labels

Comments

@mintcloud
Copy link

mintcloud commented Sep 11, 2020

0x Instant is a configurable token swap widget that connects to 0x API liquidity. Instant code is in the form of a package in the 0x-monorepo repository.
Instant is not currently being maintained by 0x Labs, but it has proven to attract a fair amount of developers experimenting with 0x for the first time. While there haven’t been any significant live applications of the widget since its launch (probably the only one live now is on ZRX Portal, deployed by 0x Labs), there are still a lot of questions on the dedicated Discord channel, which signals there is an appetite by developers to deploy hosted applications.

0x Labs proposes to fund the development of a revamped version of Instant, addressing the most commonly requested features listed in the minimum requirements.

Minimum requirements

  • Make Instant use swap/v1/quote 0x API endpoints (specs WIP, you can refer to swap/v0/quote in the official docs 1 2) instead of AssetSwapper.
    • support ERC20<>ERC20
    • support ETH unwrapping natively (sell ERC20s for ETH)
  • Utilize affiliate fees via swap/v1 (ref PR) instead of forwarder contract.
  • Create a comprehensive guide (better if with video walkthroughs and/or screenshots) for developers to customize token pairs and other settings.
  • Publish guide at 0x.org/docs .
  • Host a live version of Instant.

Nice to have

  • Design revamp
  • Revamp and host Instant Configurator to make it easier to add custom tokens

Logistics of the bounty

0x Labs will open up a gitcoin bounty (link WIP), and will give applicants 2 weeks to propose their development plan directly in the gitcoin page. The deadline to submit the plan is Sunday, October 3rd. It will be asked to applicants to present their plans at the upcoming Ecosystem and Governance call (scheduled for Wednesday, October 7th, 21pm UTC).

At the end of this period, 0x Labs will assign the bounty to the developer who prepared the best proposal. Developer experience (via github contributions and similar) will be assessed, and it will be given priority to who expresses interest in continued maintenance of the product.

The bounty will be sent to the developer once the planned work is finished and verified by 0x Labs. In the meantime, 0x Labs will proceed at moving 0x Instant package into its own independent repository, so to be ready once the project is assigned.

To summarize:

  • STEP 1. Interested developers read the issue, get familiar with the package and minimum requirements
  • STEP 2. 0x Labs opens a gitcoin bounty
  • STEP 3. Developer applies to bounty by proposing a plan directly in the gitcoin page. The more details in the plan the better - we don't want just applicants saying "I can work on this project". Prior experience on 0x stack will be appreciated but not required. Deadline to share the plan is Sunday, October 3rd
  • STEP 4. If further clarification is needed, applicants will be invited at the next Ecosystem call (0x Labs: Ecosystem Developer and Governance Meeting Agenda [2020.10.14] pm#32) to present the plan
  • STEP 5. The bounty is assigned to the best proposal
  • STEP 6. The developer works on the project
  • STEP 7. 0x Labs review, the developer is paid
@mintcloud mintcloud changed the title Instant revamp bake-off (w/ bounty) Instant revamp bake-off Sep 21, 2020
@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This issue now has a funding of 10000.0 ZRX (3962.16 USD @ $0.4/ZRX) attached to it.

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work has been started.

These users each claimed they can complete the work by 266 years, 1 month from now.
Please review their action plans below:

1) vjnrv has applied to start work (Funders only: approve worker | reject worker).

Hello!

My name is Pedro Junior, a Web Developer from Brazil. I'm a early investor in the 0x Project (since ICO), since then i have follow all the progress this project have done, so will be a pleasure to try to accomplish this task.

My plan to complete this task is: first do some analysis on the code, try to build and see if its working properly. The next step is to read the 0x API docs and then implement it on 0x Instant.

My questions:

  • Is if support for ERC 721 will be dropped or is required to remain its support?
  • Can i inspire me in the Matcha's UI?

Thanks for your attention and sorry for my bad english.
2) joaocampos89 has been approved to start work.

Hi 0x team, I am bringing my proposal here.

I have over 1 year experience working directly using ZRX toolchain and I am big passionate about 0x instant.

I plan to do all minimum requirements and start working asap, I estimate from 4 to 6 weeks, maybe earlier.

The wizard will be using Material UI and will have the following options:

  • Costumize tokens, add support for token lists
  • Add OTC desk to user create order
  • Costumize affiliate fee and buy token fee percentage
  • Hosted in Github sites

For Instant:

  • Integrate 0x Api swap feature and be able to do both sell and buy
  • Add Token lists support: this enable users to pass their custom list
  • Update dependencies and use hooks where possible
  • Add web3 modal or web3 React to support multiple wallets easily
    3) cristiangpr has applied to start work (Funders only: approve worker | reject worker).

Hey 0x team! I am a developer with a 100% success rate on Gitcoin. This is my proposal
Project description :

Revamp of 0x Instant

Features:

Implementation of 0x API endpoints

Update of tests as needed

TDD for:

Support for ERC20<>ERC20

Support for ETH unwrapping natively

Affiliate fees using 0x Api

Creation and publication of guide

Hosting of live version on Heroku or Digital Ocean

Revamp of Instant Configurator

Design Revamp

Timeline, Milestones and Deliverables

Phase I

Deliverables: Migrate from Asset Swapper to 0x API

Time Estimate: 1-2 weeks

Phase II

Deliverables: Add support for requested features

Time Estimate: 1-2 weeks

Phase III

Deliverables: Create and publish comprehensive guide

Time Estimate: 1 week

Phase IV

Deliverables: Live Deploy and Revamp of configurator

Time Estimate: 1 week

Phase V

Deliverables: Revamp design using Matcha assets or Material UI, Bootstrap or similar

Time Estimate 1 week

Thanks for your consideration.

Learn more on the Gitcoin Issue Details page.

@gitcoinbot
Copy link

gitcoinbot commented Oct 6, 2020

@JoaoCampos89 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

4 similar comments
@gitcoinbot
Copy link

gitcoinbot commented Oct 9, 2020

@JoaoCampos89 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@gitcoinbot
Copy link

gitcoinbot commented Oct 9, 2020

@JoaoCampos89 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@gitcoinbot
Copy link

gitcoinbot commented Oct 12, 2020

@JoaoCampos89 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@gitcoinbot
Copy link

gitcoinbot commented Oct 12, 2020

@JoaoCampos89 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@gitcoinbot
Copy link

@JoaoCampos89 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

11 similar comments
@gitcoinbot
Copy link

@JoaoCampos89 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@gitcoinbot
Copy link

@JoaoCampos89 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@gitcoinbot
Copy link

@JoaoCampos89 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@gitcoinbot
Copy link

@JoaoCampos89 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@gitcoinbot
Copy link

@JoaoCampos89 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@gitcoinbot
Copy link

@JoaoCampos89 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@gitcoinbot
Copy link

@JoaoCampos89 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@gitcoinbot
Copy link

@JoaoCampos89 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@gitcoinbot
Copy link

@JoaoCampos89 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@gitcoinbot
Copy link

@JoaoCampos89 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@gitcoinbot
Copy link

@JoaoCampos89 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@gitcoinbot
Copy link

@JoaoCampos89 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


@JoaoCampos89 due to inactivity, we have escalated this issue to Gitcoin's moderation team. Let us know if you believe this has been done in error!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@stale
Copy link

stale bot commented Dec 19, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Dec 19, 2020
@stale
Copy link

stale bot commented Jan 20, 2021

This issue has been automatically closed because no activity occured in 7 days after being marked as stale. If it's still relevant - feel free to reopen. Thank you for your contributions.

@stale stale bot closed this as completed Jan 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants