Skip to content
This repository has been archived by the owner on Jul 9, 2021. It is now read-only.

sol-compiler update link for solc binary downloads #2741

Closed
gabririgo opened this issue Oct 30, 2020 · 2 comments
Closed

sol-compiler update link for solc binary downloads #2741

gabririgo opened this issue Oct 30, 2020 · 2 comments
Labels

Comments

@gabririgo
Copy link

Expected Behavior

sol-compiler should be able to pull latest solc binanries (>0.7.2+)

new list seems to be found here: https://solc-bin.ethereum.org/bin/list.json

affected code line can be found here: 0xProject/tools#5

Current Behavior

currently fetching from https://ethereum.github.io/solc-bin/bin/list.json, which has github rate limits

Possible Solution

change link to https://solc-bin.ethereum.org/bin/list.json
another positive is it does not have rate limits, which have been affecting sol-compiler

Steps to Reproduce (for bugs)

1. run smart contract package with sol-compiler
2. use solc v.0.7.4
3. trying to compile a contract will return an error

Context

trying to upgrade package using solc 0.5.9 to 0.7.4
0.7.4 has dynamic array storage bugfix

Your Environment

| Package | Version |
| sol-compiler: | :4.1.1 -> 4.2.7 |

Network
testrpc
@stale
Copy link

stale bot commented Dec 5, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Dec 5, 2020
@gabririgo
Copy link
Author

Closing, as after this issue, 0x team has promptly updated and published the package

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant