Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make this a struct with internally named members #710

Open
recmo opened this issue Jun 10, 2020 · 0 comments
Open

Make this a struct with internally named members #710

recmo opened this issue Jun 10, 2020 · 0 comments
Assignees
Labels
refactor Improves the code quality tracker Issues generated from source comments

Comments

@recmo
Copy link
Contributor

recmo commented Jun 10, 2020

On 2020-06-10 @pvienhage wrote in bab508e “Constraint System Contract Autogen (#709)”:

Make this a struct with internally named members
the members are (index, degree bound, expression, name)

pub enum RationalExpression {
    X,
    Constant(FieldElement),
    Trace(usize, isize),
    Polynomial(DensePolynomial, Box<RationalExpression>),
    // TODO - Make this a struct with internally named members
    // the members are (index, degree bound, expression, name)
    ClaimPolynomial(usize, usize, Box<RationalExpression>, Option<&'static str>),
    Add(Box<RationalExpression>, Box<RationalExpression>),
    Neg(Box<RationalExpression>),
    Mul(Box<RationalExpression>, Box<RationalExpression>),
    Inv(Box<RationalExpression>),

From crypto/stark/src/rational_expression.rs:23

@recmo recmo added refactor Improves the code quality tracker Issues generated from source comments labels Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Improves the code quality tracker Issues generated from source comments
Projects
None yet
Development

No branches or pull requests

2 participants