Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create onchain vote infrastructure in ZRX Portal #355

Closed
mintcloud opened this issue Oct 28, 2020 · 13 comments
Closed

Create onchain vote infrastructure in ZRX Portal #355

mintcloud opened this issue Oct 28, 2020 · 13 comments

Comments

@mintcloud
Copy link
Contributor

mintcloud commented Oct 28, 2020

As mentioned in 0x’s latest governance roadmap update, 0x Labs is planning to migrate its governance infrastructure into on chain-binding systems in 2021. One of the most battle-tested smart contract architectures in this category is the one created and used by Compound. The system has been functioning smoothly since its launch, and recently adopted also by Uniswap. In Q1, we are planning to start customizing Compound’s contracts to support the governance of the 0x protocol.

In the meantime, we’re looking for someone to help us adapt ZRX Portal to support such a governance flow. More specifically the 0x.org/zrx/vote page will have to pull onchain proposals, and provide a flow for ZRX holders to vote and/or delegate their ZRX to other address. 0x specific contracts will not be available for testing this feature, but we're planning to test it with Compound's or Uniswap's implementations.

Requirements

Web2

  • create onchain vote ("proposal") page components and containers. It will likely be a simplified version of the current "zeip" page.
  • if necessary, create abstraction of 'vote page', which will accommodate both existing off-chain votes ("zeip" page, example) and onchain vote ("proposal") pages - the one added in this effort. Both vote types will have to co-exist.
  • blend the two types of page in the /zrx/vote page list. Users will be able to access them interchangeably and will be sorted chronologically.
  • add a label to identify the different statuses of the votes (Upcoming, Live, Passed, Rejected), based on status.
  • link to the 0x forum in the /zrx/vote page
  • (nice to have) label to distinguish votes coming from onchain sources ("proposal") and off-chain ("zeip").
  • create delegation widget (example in Compound and Uniswap) with popup flow to change delegation.
  • create leaderboard page, similar to Compound's. TBD where to link it from main governance page, and whether to have a widget embedded there.

Web3

  • connect through infura/alchemy (already available in ZRX Portal) to pull onchain proposals from either Uniswap or Compound
  • populate "proposal" page with the information pulled onchain. You can refer to examples like this 1 2. The minimum set of details needed will be [Yes|No], the description, the vote start/end, the link to the onchain transaction.
  • vote on onchain votes ("proposals"), utilizing web3-react already provided in ZRX Portal
  • change delegation signing transaction, utilizing web3-react already provided in ZRX Portal
  • populate leaderboard page

This issue requires a fair amount of creative freedom when it comes to designing and architecting the page. We are looking for a dev that enjoys loosely specced projects and is autonomous in making decisions.
Experience in web3 is required. You will be working together with Theo and Paul from the 0x Platform team, and who will help you clarify the requirements and make decisions/prioritizations with you.
Theo will contact you over DM (if you left that option open on gitcoin) or over email to setup an intro call, before assigning bounty.

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This issue now has a funding of 10000.0 ZRX (3338.38 USD @ $0.33/ZRX) attached to it as part of the https://github.com/0xProject fund.

@princesinha19
Copy link

Hi @mintcloud, As I see this is an approval based bounty so, can you please approve me so that I can complete the work. I have started looking into the 0x roadmap. Thanks 🙌

@gitcoinbot
Copy link

gitcoinbot commented Nov 17, 2020

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work has been started.

These users each claimed they can complete the work by 265 years, 7 months from now.
Please review their action plans below:

1) shad-k has been approved to start work.

Hi, I have immense amount of experience with React, JavaScript and Typescript and a working experience of web3. I took a look at the codebase and have already made myself accustomed to how the code is organised. And while I don't have much governance experience I believe this is the perfect task for me to take up and learn about it.

Learn more on the Gitcoin Issue Details page.

@gitcoinbot
Copy link

@shad-k Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@shad-k
Copy link
Contributor

shad-k commented Nov 17, 2020

@shad-k Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

Just got assigned to the bounty, work starts soon 🙂

@gitcoinbot
Copy link

@shad-k Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

1 similar comment
@gitcoinbot
Copy link

@shad-k Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@shad-k
Copy link
Contributor

shad-k commented Nov 23, 2020

@mintcloud can we snooze these gitcoin warnings? Or I can create a WIP PR.

@gitcoinbot
Copy link

@shad-k Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

1 similar comment
@gitcoinbot
Copy link

@shad-k Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@shad-k
Copy link
Contributor

shad-k commented Dec 2, 2020

@gitcoinbot still working

@shad-k shad-k mentioned this issue Dec 10, 2020
@mintcloud
Copy link
Contributor Author

Issue solved by @shad-k #358

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work for 10000.0 ZRX (16235.73 USD @ $1.62/ZRX) has been submitted by:


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants