Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

N18 - Avoid using transfer() to transfer ETH #9

Closed
PhABC opened this issue Jan 6, 2020 · 2 comments
Closed

N18 - Avoid using transfer() to transfer ETH #9

PhABC opened this issue Jan 6, 2020 · 2 comments

Comments

@PhABC
Copy link
Contributor

PhABC commented Jan 6, 2020

image

By @Agusx1211
@PhABC PhABC closed this as completed in 5874e30 Jan 8, 2020
@PhABC PhABC reopened this Jan 8, 2020
@PhABC
Copy link
Contributor Author

PhABC commented Jan 8, 2020

What would be the purpose of the reentrancy check? It looks like re-entrancy is not problematic in this case.

@Agusx1211
Copy link
Member

It should pose an issue, in that case, the reentrancy lock shouldn’t be needed.

That being said, replacing transfer() with call.vale() should be enough to fix the issue.

@PhABC PhABC closed this as completed Jan 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@PhABC @Agusx1211