Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Events are using different MutableSharedFlows. #115

Closed
AniketSK opened this issue Oct 4, 2021 · 0 comments · Fixed by #118
Closed

Events are using different MutableSharedFlows. #115

AniketSK opened this issue Oct 4, 2021 · 0 comments · Fixed by #118
Labels
good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed

Comments

@AniketSK
Copy link
Contributor

AniketSK commented Oct 4, 2021

In the MeetingViewModel, there are two events. One for rtmpErrors and another for changeTrackMuteRequest.
They should be moved into a single Flow with a shared sealed data class structure.

For an explanation of what this is, look here.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Combining RTMPErrors and ChangeTrackMuteRequests Stuie/100ms-android
1 participant
@AniketSK