Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make leave easier to click than end room #445

Closed
triptu opened this issue Oct 11, 2021 · 9 comments
Closed

make leave easier to click than end room #445

triptu opened this issue Oct 11, 2021 · 9 comments
Labels

Comments

@triptu
Copy link
Contributor

triptu commented Oct 11, 2021

if you have the permission to end room, this is how the UI currently looks when clicked on leave room
Screenshot 2021-10-11 at 6 45 52 PM

It's much easier to click on end room by mistake. Two things are required -

  • Switch the order of end room and leave room, so leave is down and end is up.
  • Highlight the leave button with red color instead of the endroom
@triptu
Copy link
Contributor Author

triptu commented Oct 11, 2021

@LuizHAP can you pick this one?

@Bipul-Harsh
Copy link

if you have the permission to end room, this is how the UI currently looks when clicked on leave room Screenshot 2021-10-11 at 6 45 52 PM

It's much easier to click on end room by mistake. Two things are required -

  • Switch the order of end room and leave room, so leave is down and end is up.
  • Highlight the leave button with red color instead of the endroom

here you mean end room is down and leave room is up right?

@Bipul-Harsh
Copy link

image
Can you tell me which one is the correct output you mean

@Bipul-Harsh
Copy link

BTW I am ready to work on it so you can assign it to me

@manavdesai27
Copy link
Contributor

@triptu I have previously worked on such issues. Can I work on this one?

@manavdesai27
Copy link
Contributor

@triptu 100ms developer dashboard is down right now?

@manavdesai27
Copy link
Contributor

I have made the changes but the token might have expired.

@manavdesai27
Copy link
Contributor

@triptu please review this PR

@triptu
Copy link
Contributor Author

triptu commented Oct 12, 2021

closed in #447

@triptu triptu closed this as completed Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants